[
https://issues.apache.org/jira/browse/HDFS-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13837980#comment-13837980
]
Chris Nauroth commented on HDFS-5514:
-------------------------------------
Thanks, Daryn.
On #2, I think verifying that the lock implementation supports reentrancy is
the more significant thing than the counts returned from {{getReadHoldCount}}
and {{getWriteHoldCount}}. (i.e. Locking twice in a row is expected to succeed
with no exception thrown.) I'll defer to you on whether or not you think
that's a valuable test here.
If not, then I think the only remaining thing is the {{coarseLock}} rename.
> FSNamesystem's fsLock should allow custom implementation
> --------------------------------------------------------
>
> Key: HDFS-5514
> URL: https://issues.apache.org/jira/browse/HDFS-5514
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: 2.0.0-alpha, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HDFS-5514.patch
>
>
> Changing {{fsLock}} from a {{ReentrantReadWriteLock}} to an API compatible
> class that encapsulates the rwLock will allow for more sophisticated locking
> implementations such as fine grain locking.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
