[ https://issues.apache.org/jira/browse/HDFS-5312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13840803#comment-13840803 ]
Hadoop QA commented on HDFS-5312: --------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12617255/HDFS-5312.006.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 4 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestPersistBlocks {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5651//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5651//console This message is automatically generated. > Generate HTTP / HTTPS URL in DFSUtil#getInfoServer() based on the configured > http policy > ---------------------------------------------------------------------------------------- > > Key: HDFS-5312 > URL: https://issues.apache.org/jira/browse/HDFS-5312 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Haohui Mai > Assignee: Haohui Mai > Attachments: HDFS-5312.000.patch, HDFS-5312.001.patch, > HDFS-5312.002.patch, HDFS-5312.003.patch, HDFS-5312.004.patch, > HDFS-5312.005.patch, HDFS-5312.006.patch > > > DFSUtil#getInfoServer() returns only the authority (i.e., host+port) when > searching for the http / https server. This is insufficient because HDFS-5536 > and related jiras allows NN / DN / JN to open HTTPS only using the HTTPS_ONLY > policy. > This JIRA addresses two issues. First, DFSUtil#getInfoServer() should return > an URI instead of a string, so that the scheme is an inherent parts of the > return value, which eliminates the task of figuring out the scheme by design. > Second, it introduces a new function to choose whether http or https should > be used to connect to the remote server based of dfs.http.policy. -- This message was sent by Atlassian JIRA (v6.1#6144)