[ 
https://issues.apache.org/jira/browse/HDFS-5632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jing Zhao updated HDFS-5632:
----------------------------

    Attachment: HDFS-5632.003.patch

Thanks for the review, Nicholas! Update the patch to address the comments.

bq. but we should check precondition in 
DirectoryWithSnapshotFeature.destroyDstSubtree(..).

The destroyDstSubtree may be invoked recursively, and in some cases the given 
directory may be not with snapshot. Thus I put the Precondition check in 
INodeReference#destroyAndCollectBlocks.

> Add Snapshot feature to INodeDirectory
> --------------------------------------
>
>                 Key: HDFS-5632
>                 URL: https://issues.apache.org/jira/browse/HDFS-5632
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>         Attachments: HDFS-5632.000.patch, HDFS-5632.001.patch, 
> HDFS-5632.002.patch, HDFS-5632.003.patch
>
>
> We will add snapshot feature to INodeDirectory and remove 
> INodeDirectoryWithSnapshot in this jira.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to