[ https://issues.apache.org/jira/browse/HDFS-5669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13848436#comment-13848436 ]
Hadoop QA commented on HDFS-5669: --------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12618782/HDFS-5669.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5722//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5722//console This message is automatically generated. > Storage#tryLock() should check for null before logging successfull message > -------------------------------------------------------------------------- > > Key: HDFS-5669 > URL: https://issues.apache.org/jira/browse/HDFS-5669 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode > Affects Versions: 2.2.0 > Reporter: Vinay > Assignee: Vinay > Attachments: HDFS-5669.patch > > > In the following code in Storage#tryLock(), there is a possibility that > {{file.getChannel().tryLock()}} returns null if the lock is acquired by some > other process. In that case even though return value is null, a successfull > message confuses. > {code}try { > res = file.getChannel().tryLock(); > file.write(jvmName.getBytes(Charsets.UTF_8)); > LOG.info("Lock on " + lockF + " acquired by nodename " + jvmName); > } catch(OverlappingFileLockException oe) {{code} -- This message was sent by Atlassian JIRA (v6.1.4#6159)