[ https://issues.apache.org/jira/browse/HDFS-5657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13849631#comment-13849631 ]
Hadoop QA commented on HDFS-5657: --------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12618948/HDFS-5657.new.001.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:red}-1 eclipse:eclipse{color}. The patch failed to build with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:red}-1 release audit{color}. The applied patch generated 1 release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs-nfs. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5732//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/5732//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5732//console This message is automatically generated. > race condition causes writeback state error in NFS gateway > ---------------------------------------------------------- > > Key: HDFS-5657 > URL: https://issues.apache.org/jira/browse/HDFS-5657 > Project: Hadoop HDFS > Issue Type: Bug > Components: nfs > Reporter: Brandon Li > Assignee: Brandon Li > Attachments: HDFS-5657.001.patch, HDFS-5657.002.patch, > HDFS-5657.new.001.patch > > > A race condition between NFS gateway writeback executor thread and new write > handler thread can cause writeback state check failure, e.g., > {noformat} > 2013-11-26 10:34:07,859 DEBUG nfs3.RpcProgramNfs3 > (Nfs3Utils.java:writeChannel(113)) - WRITE_RPC_CALL_END______957880843 > 2013-11-26 10:34:07,863 DEBUG nfs3.OpenFileCtx > (OpenFileCtx.java:offerNextToWrite(832)) - The asyn write task has no pending > writes, fileId: 30938 > 2013-11-26 10:34:07,871 ERROR nfs3.AsyncDataService > (AsyncDataService.java:run(136)) - Asyn data service got > error:java.lang.IllegalStateException: The openFileCtx has false async status > at > com.google.common.base.Preconditions.checkState(Preconditions.java:145) > at > org.apache.hadoop.hdfs.nfs.nfs3.OpenFileCtx.executeWriteBack(OpenFileCtx.java:890) > at > org.apache.hadoop.hdfs.nfs.nfs3.AsyncDataService$WriteBackTask.run(AsyncDataService.java:134) > at > java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) > at java.lang.Thread.run(Thread.java:662) > 2013-11-26 10:34:07,901 DEBUG nfs3.RpcProgramNfs3 > (RpcProgramNfs3.java:write(707)) - requesed offset=917504 and current > filesize=917504 > 2013-11-26 10:34:07,902 DEBUG nfs3.WriteManager > (WriteManager.java:handleWrite(131)) - handleWrite fileId: 30938 offset: > 917504 length:65536 stableHow:0 > {noformat} -- This message was sent by Atlassian JIRA (v6.1.4#6159)