[ 
https://issues.apache.org/jira/browse/HDFS-5449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13852229#comment-13852229
 ] 

Jing Zhao commented on HDFS-5449:
---------------------------------

Do we also want to add some javadoc/comment for the changes
{code}
+    m.put("name", datanodeinfo.getXferAddr());
{code}
and 
{code}
+    if (ipAddr == null) {
+      String name = getString(m, "name", null);
{code}
just explaining why we write/read the name field?

> WebHdfs compatibility broken between 2.2 and 1.x / 23.x
> -------------------------------------------------------
>
>                 Key: HDFS-5449
>                 URL: https://issues.apache.org/jira/browse/HDFS-5449
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Kihwal Lee
>            Assignee: Kihwal Lee
>            Priority: Blocker
>         Attachments: HDFS-5449.patch, HDFS-5449.patch, HDFS-5449.trunk.patch
>
>
> Similarly to HDFS-5403, getFileBlockLocations() fail between old (1.x, 
> 0.23.x) and new (2.x), but this is worse since both directions won't work.  
> This is caused by the removal of "name" field from the serialized json format 
> of DatanodeInfo. 
> 2.x namenode should include "name" (ip:port) in the response and 2.x webhdfs 
> client should use "name", if "ipAddr" and "xferPort" don't exist in the 
> response. 



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to