[ https://issues.apache.org/jira/browse/HDFS-5676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13852314#comment-13852314 ]
Hudson commented on HDFS-5676: ------------------------------ SUCCESS: Integrated in Hadoop-trunk-Commit #4913 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/4913/]) HDFS-5676. fix inconsistent synchronization of CachingStrategy (cmccabe) (cmccabe: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1552162) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSOutputStream.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/CachingStrategy.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestConnCache.java > fix inconsistent synchronization of CachingStrategy > --------------------------------------------------- > > Key: HDFS-5676 > URL: https://issues.apache.org/jira/browse/HDFS-5676 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs-client > Affects Versions: 2.4.0 > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Priority: Minor > Fix For: 2.4.0 > > Attachments: HDFS-5676.001.patch, HDFS-5676.003.patch > > > Currently, the synchronization for {{CachingStrategy}} is a little > inconsistent. DFSOutputStream#setDropBehind modifies the strategy object, > but there's nothing protecting that object against concurrent use in > {{createBlockOutputStream}}. Similarly, {{DFSInputStream#setDropBehind}} is > synchronized, but not all the uses of {{cachingStrategy}} are. -- This message was sent by Atlassian JIRA (v6.1.4#6159)