[ https://issues.apache.org/jira/browse/HDFS-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13854717#comment-13854717 ]
Colin Patrick McCabe commented on HDFS-5659: -------------------------------------------- bq. Like I said earlier, the names of PBHelper#convertDatanodeInfo and PBHelper#convert don't suggest what the differences are between them, or what reason I would have for using one rather than the other. Please, use descriptive names here. actually, let's move this refactoring issue to HDFS-5694. We'll want to do that in branch-2 as well, for one thing. > dfsadmin -report doesn't output cache information properly > ---------------------------------------------------------- > > Key: HDFS-5659 > URL: https://issues.apache.org/jira/browse/HDFS-5659 > Project: Hadoop HDFS > Issue Type: Bug > Components: caching > Affects Versions: 3.0.0 > Reporter: Akira AJISAKA > Assignee: Andrew Wang > Attachments: hdfs-5659-1.patch, hdfs-5659-2.patch > > > I tried to cache a file by "hdfs cacheadmin -addDirective". > I thought the file was cached because "CacheUsed" at jmx was more than 0. > {code} > { > "name" : > "Hadoop:service=DataNode,name=FSDatasetState-DS-1043926324-172.28.0.102-50010-1385087929296", > "modelerType" : > "org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl", > "Remaining" : 5604772597760, > "StorageInfo" : "FSDataset{dirpath='[/hadoop/data1/dfs/data/current, > /hadoop/data2/dfs/data/current, /hadoop/data3/dfs/data/current]'}", > "Capacity" : 5905374474240, > "DfsUsed" : 11628544, > "CacheCapacity" : 1073741824, > "CacheUsed" : 360448, > "NumFailedVolumes" : 0, > "NumBlocksCached" : 1, > "NumBlocksFailedToCache" : 0, > "NumBlocksFailedToUncache" : 0 > }, > {code} > But "dfsadmin -report" didn't output the same value as jmx. > {code} > Configured Cache Capacity: 0 (0 B) > Cache Used: 0 (0 B) > Cache Remaining: 0 (0 B) > Cache Used%: 100.00% > Cache Remaining%: 0.00% > {code} -- This message was sent by Atlassian JIRA (v6.1.4#6159)