[
https://issues.apache.org/jira/browse/HDFS-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13861760#comment-13861760
]
Andrew Wang commented on HDFS-5709:
-----------------------------------
Hey Suresh, could you elaborate a bit on your -1? From my read of HDFS-4666,
others seemed basically okay with the idea of automatic renaming. I'm
considering it since telling the user at this late stage isn't very friendly.
They'll have to rollback, swap all their jars, fix the .snapshot paths, then
upgrade again. Also, unless we enumerate all the erroneous .snapshot paths,
fixing all of them is somewhat error-prone.
Another possibility is making this a separate tool that users can run
pre-upgrade, but that still means possibly doing the rollback dance if someone
doesn't read the release notes.
> Improve upgrade with existing files and directories named ".snapshot"
> ---------------------------------------------------------------------
>
> Key: HDFS-5709
> URL: https://issues.apache.org/jira/browse/HDFS-5709
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Affects Versions: 3.0.0, 2.2.0
> Reporter: Andrew Wang
> Labels: snapshots, upgrade
>
> Right now in trunk, upgrade fails messily if the old fsimage or edits refer
> to a directory named ".snapshot". We should at least print a better error
> message (which I believe was the original intention in HDFS-4666), and [~atm]
> proposed automatically renaming these files and directories.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
