[ https://issues.apache.org/jira/browse/HDFS-5721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13863967#comment-13863967 ]
Junping Du commented on HDFS-5721: ---------------------------------- Thanks for nice catch again. Ted! There are also other places with the similar issues that not get close in finally block. i.e. Namenode#Format(), FSNamesystem# loadFromDisk(), etc. I think we should fix all these similar issues in one JIRA. > sharedEditsImage in Namenode#initializeSharedEdits() should be closed before > method returns > ------------------------------------------------------------------------------------------- > > Key: HDFS-5721 > URL: https://issues.apache.org/jira/browse/HDFS-5721 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Ted Yu > Priority: Minor > > At line 901: > {code} > FSImage sharedEditsImage = new FSImage(conf, > Lists.<URI>newArrayList(), > sharedEditsDirs); > {code} > sharedEditsImage is not closed before the method returns. -- This message was sent by Atlassian JIRA (v6.1.5#6160)