[ https://issues.apache.org/jira/browse/HDFS-5612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13871300#comment-13871300 ]
Haohui Mai commented on HDFS-5612: ---------------------------------- The patch looks good. nit: you might be able to simplify the code a little bit by consolidating the if branches in {{checkAccessAcl}}. > NameNode: change all permission checks to enforce ACLs in addition to > permissions. > ---------------------------------------------------------------------------------- > > Key: HDFS-5612 > URL: https://issues.apache.org/jira/browse/HDFS-5612 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: namenode > Affects Versions: HDFS ACLs (HDFS-4685) > Reporter: Chris Nauroth > Assignee: Chris Nauroth > Attachments: HDFS-5612.1.patch, HDFS-5612.2.patch, HDFS-5612.3.patch > > > All {{NameNode}} code paths that enforce permissions must be updated so that > they also enforce ACLs. -- This message was sent by Atlassian JIRA (v6.1.5#6160)