[
https://issues.apache.org/jira/browse/HDFS-5743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13875441#comment-13875441
]
Haohui Mai commented on HDFS-5743:
----------------------------------
The patch looks good. There are some indentation issues in the code:
{code}
+ message INodeReference {
+ // id of the referred inode
+ optional uint64 referredId = 1;
+ // local name recorded in WithName
+ optional bytes name = 2;
+ // recorded in DstReference
+ optional uint32 dstSnapshotId = 3;
+ // recorded in WithName
+ optional uint32 lastSnapshotId = 4;
+ }
{code}
{code}
+ repeated uint64 deleted = 8; // id of deleted inode
{code}
You might want to rename it to {{deletedINode}}.
You can also get rid of the changes in {{TestRenameWithSnapshots}}, which
should make the merge easier.
There are trailing whitespaces in the patch as well.
> Use protobuf to serialize snapshot information
> ----------------------------------------------
>
> Key: HDFS-5743
> URL: https://issues.apache.org/jira/browse/HDFS-5743
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Haohui Mai
> Assignee: Jing Zhao
> Attachments: HDFS-5743.000.patch, HDFS-5743.001.patch,
> HDFS-5743.002.patch
>
>
> This jira tracks the efforts of using protobuf to serialize snapshot-related
> information in FSImage.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
