[
https://issues.apache.org/jira/browse/HDFS-5615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13877023#comment-13877023
]
Haohui Mai commented on HDFS-5615:
----------------------------------
Looks good to me. Nit: You might be able to write a helper method to simplify
both {{testAclMovingFiles()}} and {{testMovingFiles()}}. For example:
{code}
private void testMovingFileHelper(boolean useAcl) {
// construct files
if (useAcl) {
applyAcl(...);
}
// test
}
public void testMovingFile() {
testMovingFileHelper(false);
}
public void testAclMovingFile() {
testMovingFileHelper(true);
}
{code}
Alternatively, combining them also works.
> NameNode: implement handling of ACLs in combination with sticky bit.
> --------------------------------------------------------------------
>
> Key: HDFS-5615
> URL: https://issues.apache.org/jira/browse/HDFS-5615
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: HDFS ACLs (HDFS-4685)
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Attachments: HDFS-5615.1.patch
>
>
> The sticky bit must work in combination with ACLs, similar to how the sticky
> bit already works with permissions.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
