[ https://issues.apache.org/jira/browse/HDFS-5703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13877908#comment-13877908 ]
Aaron T. Myers commented on HDFS-5703: -------------------------------------- Patch looks pretty good to me, and I agree that the javadoc warnings are unrelated. A few small comments: # I find the use of the static {{kind}} in {{DelegationTokenIdentifier}} to be a bit gross. How about make it not static, and just set an instance variable appropriately in {{DelegationTokenManagerService}} and then create all {{DelegationTokenIdentifiers}} using that instance variable? # Why the extra spaces here after 'Using'? 'print "Using HTTPFS_SSL_ENABLED: ${HTTPFS_SSL_ENABLED}"' Likewise in a few other places as well. # Is this statement in the documentation for real? Seems bizarre to me: '+ The answer to "What is your first and last name?" (i.e. "CN") must be the + hostname of the machine where the HttpFS Server will be running.' +1 once these are addressed. > Add support for HTTPS and swebhdfs to HttpFS > -------------------------------------------- > > Key: HDFS-5703 > URL: https://issues.apache.org/jira/browse/HDFS-5703 > Project: Hadoop HDFS > Issue Type: New Feature > Components: webhdfs > Affects Versions: 2.4.0 > Reporter: Alejandro Abdelnur > Assignee: Alejandro Abdelnur > Attachments: HDFS-5703.patch > > > HDFS-3987 added HTTPS support to webhdfs, using the new scheme swebhdfs://. > This JIRA is to add HTTPS support to HttpFS as well as supporting the > DelegationTokens required by swebhdfs:// -- This message was sent by Atlassian JIRA (v6.1.5#6160)