[ 
https://issues.apache.org/jira/browse/HDFS-5585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13885590#comment-13885590
 ] 

Vinay commented on HDFS-5585:
-----------------------------

changes looks good kihwal.

some minor suggestions
you might want to add "\n" at the end of these lines for better looking,
bq. +    String shutdownDatanode = "-shutdownDatanode <datanode_host:ipc_port> 
\[upgrade\]" +

bq. +    String pingDatanode = "-pingDatanode <datanode_host:ipc_port>" +

> Provide admin commands for data node upgrade
> --------------------------------------------
>
>                 Key: HDFS-5585
>                 URL: https://issues.apache.org/jira/browse/HDFS-5585
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, ha, hdfs-client, namenode
>            Reporter: Kihwal Lee
>            Assignee: Kihwal Lee
>         Attachments: HDFS-5585.patch
>
>
> Several new methods to ClientDatanodeProtocol may need to be added to support 
> querying version, initiating upgrade, etc.  The admin CLI needs to be added 
> as well. This primary use case is for rolling upgrade, but this can be used 
> for preparing for a graceful restart of a data node for any reasons.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to