[ https://issues.apache.org/jira/browse/HDFS-5918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13896321#comment-13896321 ]
Hadoop QA commented on HDFS-5918: --------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12627927/HDFS-5918.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6093//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6093//console This message is automatically generated. > Avoid logging unnecessary trace in IPCLoggerChannel#close() > ----------------------------------------------------------- > > Key: HDFS-5918 > URL: https://issues.apache.org/jira/browse/HDFS-5918 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Vinayakumar B > Assignee: Vinayakumar B > Priority: Minor > Attachments: HDFS-5918.patch > > > Avoid logging stack trace while close() in IPCLoggerChannel. > {code} @Override > public void close() { > QuorumJournalManager.LOG.info("Closing", new Exception()); > // No more tasks may be submitted after this point. > executor.shutdown(); > if (proxy != null) { > // TODO: this can hang for quite some time if the client > // is currently in the middle of a call to a downed JN. > // We should instead do this asynchronously, and just stop > // making any more calls after this point (eg clear the queue) > RPC.stopProxy(proxy); > } > }{code} > This might have been left out by mistake in HDFS-5074 -- This message was sent by Atlassian JIRA (v6.1.5#6160)