[
https://issues.apache.org/jira/browse/HDFS-5907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13900816#comment-13900816
]
Suresh Srinivas commented on HDFS-5907:
---------------------------------------
Nice test! Have you tested this with multiple storage directories on the
datanode?
Comments for the new patch:
# testDataNodeRollingUpgradeWithRollback()
#* adds two 10s sleep. This can add to the time unit tests take to run. Is that
much time necessary?
#* Also once the file is deleted, why try to read the file? Just file exists or
not check is sufficient. You could also see if the block is indeed deleted by
asking FSNamesystem?
> Handle block deletion requests during rolling upgrades
> ------------------------------------------------------
>
> Key: HDFS-5907
> URL: https://issues.apache.org/jira/browse/HDFS-5907
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode
> Affects Versions: HDFS-5535 (Rolling upgrades)
> Reporter: Arpit Agarwal
> Assignee: Arpit Agarwal
> Attachments: HDFS-5907.01.patch, HDFS-5907.02.patch,
> HDFS-5907.04.patch, HDFS-5907.05.patch, patch-v04-v05.diff
>
>
> DN changes when a rolling upgrade is in progress:
> # DataNode should handle block deletions by moving block files to 'trash'.
> # Block files should be restored to their original locations during a
> rollback.
> # Purge trash when the rolling upgrade is finalized.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
