[ 
https://issues.apache.org/jira/browse/HDFS-5913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13901431#comment-13901431
 ] 

Hudson commented on HDFS-5913:
------------------------------

FAILURE: Integrated in Hadoop-Hdfs-trunk #1673 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1673/])
HDFS-5913. Nfs3Utils#getWccAttr() should check attr parameter against null. 
Contributed by Brandon Li (brandonli: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1568076)
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/RpcProgramNfs3.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt


> Nfs3Utils#getWccAttr() should check attr parameter against null
> ---------------------------------------------------------------
>
>                 Key: HDFS-5913
>                 URL: https://issues.apache.org/jira/browse/HDFS-5913
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: nfs
>            Reporter: Ted Yu
>            Assignee: Brandon Li
>            Priority: Minor
>             Fix For: 2.4.0
>
>         Attachments: HDFS-5913.patch
>
>
> In RpcProgramNfs3#commit() :
> {code}
>       Nfs3FileAttributes postOpAttr = null;
>       try {
>         postOpAttr = writeManager.getFileAttr(dfsClient, handle, iug);
>       } catch (IOException e1) {
>         LOG.info("Can't get postOpAttr for fileId: " + handle.getFileId());
>       }
>       WccData fileWcc = new WccData(Nfs3Utils.getWccAttr(preOpAttr), 
> postOpAttr);
> {code}
> If there is exception, postOpAttr would be null.
> However, Nfs3Utils#getWccAttr() dereferences attr parameter directly.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to