[ 
https://issues.apache.org/jira/browse/HDFS-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13907446#comment-13907446
 ] 

Chris Nauroth commented on HDFS-5981:
-------------------------------------

Thanks, Haohui.  The patch looks good.  Would it be possible to add a test that 
runs the XML processor on an fsimage containing snapshots, and then asserts 
that the output is well-formed XML?


> PBImageXmlWriter generates malformed XML
> ----------------------------------------
>
>                 Key: HDFS-5981
>                 URL: https://issues.apache.org/jira/browse/HDFS-5981
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Haohui Mai
>            Assignee: Haohui Mai
>            Priority: Minor
>         Attachments: HDFS-5981.000.patch, HDFS-5981.001.patch
>
>
> {{PBImageXmlWriter}} outputs malformed XML file because it closes the 
> {{SnapshotDiffSection}}, {{NameSection}} and {{INodeReferenceSection}} 
> incorrectly.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to