[ https://issues.apache.org/jira/browse/HDFS-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jing Zhao updated HDFS-5982: ---------------------------- Resolution: Fixed Fix Version/s: 2.4.0 Status: Resolved (was: Patch Available) Thanks for the review, Chris! I've committed this to trunk, branch-2 and branch-2.4.0. > Need to update snapshot manager when applying editlog for deleting a > snapshottable directory > -------------------------------------------------------------------------------------------- > > Key: HDFS-5982 > URL: https://issues.apache.org/jira/browse/HDFS-5982 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Affects Versions: 2.3.0 > Reporter: Tassapol Athiapinya > Assignee: Jing Zhao > Priority: Critical > Fix For: 2.4.0 > > Attachments: HDFS-5982.000.patch, HDFS-5982.001.patch, > HDFS-5982.001.patch > > > Currently after deleting a snapshottable directory which does not have > snapshots any more, we also remove the directory from the snapshottable > directory list in SnapshotManager. This works fine when handling a delete > request from user. However, when we apply the OP_DELETE editlog, > FSDirectory#unprotectedDelete(String, long) is called, which does not contain > the "updating snapshot manager" process. This may leave an non-existent inode > id in the snapshottable directory list, and can even lead to FSImage > corruption. -- This message was sent by Atlassian JIRA (v6.1.5#6160)