[ https://issues.apache.org/jira/browse/HDFS-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911415#comment-13911415 ]
Hadoop QA commented on HDFS-5956: --------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12630900/HDFS-5956.3.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6227//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6227//console This message is automatically generated. > A file size is multiplied by the replication factor in 'hdfs oiv -p > FileDistribution' option > -------------------------------------------------------------------------------------------- > > Key: HDFS-5956 > URL: https://issues.apache.org/jira/browse/HDFS-5956 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: tools > Affects Versions: 3.0.0, 2.4.0 > Reporter: Akira AJISAKA > Assignee: Akira AJISAKA > Labels: newbie > Attachments: HDFS-5956.2.patch, HDFS-5956.3.patch, HDFS-5956.patch > > > In FileDistributionCalculator.java, > {code} > long fileSize = 0; > for (BlockProto b : f.getBlocksList()) { > fileSize += b.getNumBytes() * f.getReplication(); > } > maxFileSize = Math.max(fileSize, maxFileSize); > totalSpace += fileSize; > {code} > should be > {code} > long fileSize = 0; > for (BlockProto b : f.getBlocksList()) { > fileSize += b.getNumBytes(); > } > maxFileSize = Math.max(fileSize, maxFileSize); > totalSpace += fileSize * f.getReplication(); > {code} -- This message was sent by Atlassian JIRA (v6.1.5#6160)