[ 
https://issues.apache.org/jira/browse/HDFS-6020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kihwal Lee updated HDFS-6020:
-----------------------------

    Attachment: HDFS-6020.patch

The patch fixes 4 findbugs warnings. 
- Three were for ignoring return value of File.delete(). Moved them into a 
conditional statement and added logging.
- Fourth was for not closing a FileWriter instance in some cases. This was 
originally ignored since it is non-critical and during shutdown. A finally 
block has been added to close it at all times.

The fifth warning is not something introduced by recent changes. There already 
is an entry in the exception list for this. So I am not fixing this.

{panel}
     <Match>
       <Class 
name="org.apache.hadoop.hdfs.DFSClient$DFSOutputStream$DataStreamer$ResponseProcessor"
 />
       <Method name="run" />
       <Bug pattern="REC_CATCH_EXCEPTION" />
     </Match>
{panel}

> Fix the five findbugs warnings
> ------------------------------
>
>                 Key: HDFS-6020
>                 URL: https://issues.apache.org/jira/browse/HDFS-6020
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, ha, hdfs-client, namenode
>            Reporter: Kihwal Lee
>            Assignee: Kihwal Lee
>         Attachments: HDFS-6020.patch
>
>
> The latest build of the HDFS-5535 branch (rolling upgrades) shows five new 
> findbugs warnings.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to