[ https://issues.apache.org/jira/browse/HDFS-6020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13913118#comment-13913118 ]
Chris Nauroth commented on HDFS-6020: ------------------------------------- Hi, Kihwal. This patch looks good. Minor nit: the finally block for closing the {{FileWriter}} could be simplified to a one-liner using {{IOUtils#cleanup}} or {{IOUtils#closeStream}}. +1 after that's addressed. Thanks! > Fix the five findbugs warnings > ------------------------------ > > Key: HDFS-6020 > URL: https://issues.apache.org/jira/browse/HDFS-6020 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: datanode, ha, hdfs-client, namenode > Reporter: Kihwal Lee > Assignee: Kihwal Lee > Attachments: HDFS-6020.patch > > > The latest build of the HDFS-5535 branch (rolling upgrades) shows five new > findbugs warnings. -- This message was sent by Atlassian JIRA (v6.1.5#6160)