[
https://issues.apache.org/jira/browse/HDFS-5950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13917722#comment-13917722
]
Colin Patrick McCabe commented on HDFS-5950:
--------------------------------------------
The test failure is HDFS-5997, not caused by this patch.
Thanks for the reviews, committing.
As I pointed out above, the javadoc warning is about another use of
sun.misc.Unsafe. Nothing we can do for this one.
The findbugs warnings are not valid. One warning is just because
{{DfsClientShmManager#allocSlot}} has a reverse critical section (where it
drops the lock and then retakes it at the end of the section), and findbugs
can't understand this. (TThe JavaDoc is pretty clear that the lock needs to be
held coming into the function and the finally section on the reverse critical
section relocks it.) Another is a warning about an integer multiplication with
a constant that can't possibly overflow, but findbugs can't figure this out.
> The DFSClient and DataNode should use shared memory segments to communicate
> short-circuit information
> -----------------------------------------------------------------------------------------------------
>
> Key: HDFS-5950
> URL: https://issues.apache.org/jira/browse/HDFS-5950
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, hdfs-client
> Affects Versions: 2.4.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-5950.001.patch, HDFS-5950.003.patch,
> HDFS-5950.004.patch, HDFS-5950.006.patch, HDFS-5950.007.patch,
> HDFS-5950.008.patch
>
>
> The DFSClient and DataNode should use the shared memory segments and unified
> cache added in the other HDFS-5182 subtasks to communicate short-circuit
> information.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
