[ 
https://issues.apache.org/jira/browse/HDFS-6007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918466#comment-13918466
 ] 

Colin Patrick McCabe commented on HDFS-6007:
--------------------------------------------

thanks for looking at this.

{code}
-  To configure short-circuit local reads, you will need to enable
+  To enable short-circuit local reads, you will need to enable
{code}

I like the original sentence better here.

bq. [giant table of configuration]

I'm not too excited about the giant table of configuration.  It seems to 
duplicate what we have in {{hdfs-defaults.xml}}.  We already have the problem 
of the configuration keys being duplicated between {{DFSConfigKeys.java}} and 
{{hdfs-defaults.xml}}; adding a third duplicated area seems suboptimal.

Additionally, most users will never have to configure anything related to 
HDFS-5810.  I think maybe we should just add a sentence or two about the shared 
memory segments, but certainly not describe every possible thing that you could 
conceivably configure.  Remember, this is an introduction to SCR.

> Update documentation about short-circuit local reads
> ----------------------------------------------------
>
>                 Key: HDFS-6007
>                 URL: https://issues.apache.org/jira/browse/HDFS-6007
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: documentation
>            Reporter: Masatake Iwasaki
>            Priority: Minor
>         Attachments: HDFS-6007-0.patch
>
>
> updating the contents of "HDFS SHort-Circuit Local Reads" based on the 
> changes in HDFS-5810.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to