[ 
https://issues.apache.org/jira/browse/HDFS-6044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920163#comment-13920163
 ] 

Jing Zhao commented on HDFS-6044:
---------------------------------

The patch looks good to me. Some minor comments:
# We may want to define the constant string somewhere in the following code?
{code}
"+    timeout = conf.getLong("hadoop.nfs3.userupdate.ms", TIMEOUT_DEFAULT);"
{code}
# Can we declare timeout as final and initialize it in the two constructors?

Other than that +1.

> Add property for setting the NFS look up time for users
> -------------------------------------------------------
>
>                 Key: HDFS-6044
>                 URL: https://issues.apache.org/jira/browse/HDFS-6044
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: nfs
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Minor
>         Attachments: HDFS-6044.001.patch, HDFS-6044.002.patch
>
>
> Currently NFS gateway refresh the user account every 15 minutes. Add a 
> property to make it tunable in different environments. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to