[
https://issues.apache.org/jira/browse/HDFS-6100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13935411#comment-13935411
]
Jing Zhao commented on HDFS-6100:
---------------------------------
The patch looks pretty good to me. Some minor comments:
# In DatanodeWebHdfsMethods, the current patch has some inconsistent field name
for the NamenodeAddressParam parameter (nnId, namenodeId, and
namenodeRpcAddress). How about just calling them "namenode" since it can be
either NameService ID or NameNode RPC address?
# Nit: the following code needs some reformat:
{code}
tokenServiceName = HAUtil.isHAEnabled(conf,
nsId) ? nsId : NetUtils.getHostPortString
(rpcServer.getRpcAddress());
{code}
# In the new unit test, we can add some extra check about the content of the
new created file. Also, maybe we can try to transition the second NN to active
first so that the first create call can also hit a failover.
# Looks like the patch also fixes the token service name in HA setup for
webhdfs. Please update the description of the jira.
# Could you also post your system test results (HA, non-HA, secured, insecure
setup etc.)?
> DataNodeWebHdfsMethods does not failover in HA mode
> ---------------------------------------------------
>
> Key: HDFS-6100
> URL: https://issues.apache.org/jira/browse/HDFS-6100
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: ha
> Affects Versions: 2.4.0
> Reporter: Arpit Gupta
> Assignee: Haohui Mai
> Attachments: HDFS-6100.000.patch
>
>
> In {{DataNodeWebHdfsMethods}}, the code creates a {{DFSClient}} to connect to
> the NN, so that it can access the files in the cluster.
> {{DataNodeWebHdfsMethods}} relies on the address passed in the URL to locate
> the NN. Currently the parameter is set by the NN and it is a host-ip pair,
> which does not support HA.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
