[ https://issues.apache.org/jira/browse/HDFS-6094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13935859#comment-13935859 ]
Hadoop QA commented on HDFS-6094: --------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12634845/HDFS-6094.03.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 2 new or modified test files. {color:red}-1 javac{color}. The applied patch generated 1540 javac compiler warnings (more than the trunk's current 1531 warnings). {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6407//testReport/ Javac warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/6407//artifact/trunk/patchprocess/diffJavacWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6407//console This message is automatically generated. > The same block can be counted twice towards safe mode threshold > --------------------------------------------------------------- > > Key: HDFS-6094 > URL: https://issues.apache.org/jira/browse/HDFS-6094 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Affects Versions: 2.4.0 > Reporter: Arpit Agarwal > Assignee: Arpit Agarwal > Attachments: HDFS-6094.03.patch, HDFS-6904.01.patch, > TestHASafeMode-output.txt > > > {{BlockManager#addStoredBlock}} can cause the same block can be counted > towards safe mode threshold. We see this manifest via > {{TestHASafeMode#testBlocksAddedWhileStandbyIsDown}} failures on Ubuntu. More > details to follow in a comment. > Exception details: > {code} > Time elapsed: 12.874 sec <<< FAILURE! > java.lang.AssertionError: Bad safemode status: 'Safe mode is ON. The reported > blocks 7 has reached the threshold 0.9990 of total blocks 6. The number of > live datanodes 3 has reached the minimum number 0. Safe mode will be turned > off automatically in 28 seconds.' > at org.junit.Assert.fail(Assert.java:93) > at org.junit.Assert.assertTrue(Assert.java:43) > at > org.apache.hadoop.hdfs.server.namenode.ha.TestHASafeMode.assertSafeMode(TestHASafeMode.java:493) > at > org.apache.hadoop.hdfs.server.namenode.ha.TestHASafeMode.testBlocksAddedWhileStandbyIsDown(TestHASafeMode.java:660) > {code} -- This message was sent by Atlassian JIRA (v6.2#6252)