[ 
https://issues.apache.org/jira/browse/HDFS-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13939180#comment-13939180
 ] 

Hadoop QA commented on HDFS-6115:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12635277/HDFS-6115.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/6421//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6421//console

This message is automatically generated.

> flush() should be called for every append on block scan verification log
> ------------------------------------------------------------------------
>
>                 Key: HDFS-6115
>                 URL: https://issues.apache.org/jira/browse/HDFS-6115
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>    Affects Versions: 2.3.0, 2.4.0
>            Reporter: Vinayakumar B
>            Assignee: Vinayakumar B
>         Attachments: HDFS-6115.patch
>
>
> {{RollingLogsImpl#out}} is  {{PrintWriter}} and it have the default 
> buffersize of 8kB.
> So until the 8kB buffer is filled all scan verification entries will not be 
> flushed, hence there will be chance loosing this scan information if the 
> datanode gets restarted. And One more scan will happen for these blocks.
> 8kB will have ~80 entries, so 80 blocks needs to be re-scanned again.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to