[
https://issues.apache.org/jira/browse/HDFS-6127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13941149#comment-13941149
]
Jing Zhao commented on HDFS-6127:
---------------------------------
The patch looks good to me. Some comments:
# Nit: HAUtil#getServiceUriFromToken and TokenManager#getInstance need format.
# javadoc of HAUtil#getServiceUriFromToken needs to be updated after the
change: the method now can support URI of other FS, not just HDFS.
# The change in TestWebhdfsForHA actually weakens our unit test, I think. We
still need the fs.renew and fs.cancel for regression of HDFS-5339. A separate
unit test with some code copy should be fine here, I guess.
{code}
- fs.renewDelegationToken(token);
- fs.cancelDelegationToken(token);
+ token.renew(conf);
+ token.cancel(conf);
{code}
+1 after addressing the comments.
> WebHDFS tokens cannot be renewed in HA setup
> --------------------------------------------
>
> Key: HDFS-6127
> URL: https://issues.apache.org/jira/browse/HDFS-6127
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: ha
> Affects Versions: 2.4.0
> Reporter: Arpit Gupta
> Assignee: Haohui Mai
> Attachments: HDFS-6127.000.patch
>
>
> {{TokenAspect}} class assumes that the service name of the token is alway a
> host-ip pair. In HA setup, however, the service name becomes the name service
> id, which breaks the assumption. As a result, WebHDFS tokens cannot be
> renewed in HA setup.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
