[ https://issues.apache.org/jira/browse/HDFS-6147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13944949#comment-13944949 ]
Hadoop QA commented on HDFS-6147: --------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12636312/HDFS-6147.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 2 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:red}-1 findbugs{color}. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.blockmanagement.TestOverReplicatedBlocks org.apache.hadoop.hdfs.server.datanode.TestMultipleNNDataBlockScanner org.apache.hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage org.apache.hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport org.apache.hadoop.hdfs.TestDatanodeBlockScanner {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6472//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/6472//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6472//console This message is automatically generated. > New blocks scanning will be delayed due to issue in > BlockPoolSliceScanner#updateBytesToScan(..) > ----------------------------------------------------------------------------------------------- > > Key: HDFS-6147 > URL: https://issues.apache.org/jira/browse/HDFS-6147 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode > Affects Versions: 2.4.0 > Reporter: Vinayakumar B > Assignee: Vinayakumar B > Attachments: HDFS-6147.patch > > > New blocks scanning will be delayed if old blocks deleted after datanode > restart. > Steps: > 1. Write some blocks and wait till all scans over > 2. Restart the datanode > 3. Delete some of the blocks > 4. Write new blocks which are less in size compared to deleted blocks. > Problem: > {{BlockPoolSliceScanner#updateBytesToScan(..)}} updates {{bytesLeft}} based > on following comparison > {code} if (lastScanTime < currentPeriodStart) { > bytesLeft += len; > }{code} > But in {{BlockPoolSliceScanner#assignInitialVerificationTimes()}} > {{bytesLeft}} decremented using below comparison > {code}if (now - entry.verificationTime < scanPeriod) {{code} > Hence when the old blocks are deleted {{bytesLeft}} going negative. > new blocks will not be scanned until it becomes positive again. > So in both places verificationtime should be compared against scanperiod. -- This message was sent by Atlassian JIRA (v6.2#6252)