[ 
https://issues.apache.org/jira/browse/HDFS-6156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951155#comment-13951155
 ] 

Haohui Mai commented on HDFS-6156:
----------------------------------

Looks good to me. +1.

Nit: there are a bunch of trailing whitespace in the patch. I'll go ahead and 
commit this patch using {{git apply --whitespace=fix}}, but it would be great 
if the patch can be cleaned up next time.

> Simplify the JMX API that provides snapshot information
> -------------------------------------------------------
>
>                 Key: HDFS-6156
>                 URL: https://issues.apache.org/jira/browse/HDFS-6156
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Haohui Mai
>            Assignee: Shinichi Yamashita
>         Attachments: HDFS-6156-2.patch, HDFS-6156.patch
>
>
> HDFS-5196 introduces a set of new APIs that provide snapshot information 
> through JMX. Currently. The API nests {{SnapshotDirectoryMXBean}} into 
> {{SnapshotStatsMXBean}}, creating another layer of composition.
> This jira proposes to inline {{SnapshotDirectoryMXBean}} into 
> {{SnapshotStatsMXBean}} and to simplify the API.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to