[jira] [Commented] (HDFS-6073) NameNodeResourceChecker prints 'null' mount point to the log

[Uma Maheswara Rao G (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HDFS-6073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958795#comment-13958795
 ] 

Uma Maheswara Rao G commented on HDFS-6073:
-------------------------------------------

Thanks for reporting. Seems like this patch is not fixing the root problem for 
null.


The actual cause for null would be that getFileSystem method is not parsing the 
df command output?
{code}
 } else {
      run();
      return filesystem;
    }
{code}
So, just executing the command and parseExecResult is just adding result lines 
to output in DF. So, at that stage fileSystem and mount variable will be null 
only.
If some one calls getMount then only these variable getting updated as getMount 
is parsing the output after df command execution.
{code}
} else {
      run();
      // Skip parsing if df was not successful
      if (getExitCode() != 0) {
        StringBuffer sb = new StringBuffer("df could not be run successfully: 
");
        for (String line: output) {
          sb.append(line);
        }
        throw new IOException(sb.toString());
      }
      parseOutput();
    }
{code}

So, may be the right fix could be to parse the output after getting file 
system.  I think the message says volume, so displaying filesystem there would 
be correct and if you want to show mount point, then we could display that as 
well in the log.


> NameNodeResourceChecker prints 'null' mount point to the log
> ------------------------------------------------------------
>
>                 Key: HDFS-6073
>                 URL: https://issues.apache.org/jira/browse/HDFS-6073
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.3.0
>            Reporter: Akira AJISAKA
>            Assignee: Akira AJISAKA
>         Attachments: HDFS-6073.patch
>
>
> If the available space on the volume used for saving fsimage is less than 
> 100MB (default), NameNodeResourceChecker prints the log as follows:
> {code}
> Space available on volume 'null' is 92274688, which is below the configured 
> reserved amount 104857600
> {code}
> It should print an appropriate mount point instead of null.



--
This message was sent by Atlassian JIRA
(v6.2#6252)