[ 
https://issues.apache.org/jira/browse/HDFS-6197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13962290#comment-13962290
 ] 

Hudson commented on HDFS-6197:
------------------------------

SUCCESS: Integrated in Hadoop-trunk-Commit #5465 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/5465/])
HDFS-6197. Rolling upgrade rollback on Windows can fail attempting to rename 
edit log segment files to a destination that already exists. Contributed by 
Chris Nauroth. (cnauroth: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1585586)
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FileJournalManager.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRollingUpgrade.java


> Rolling upgrade rollback on Windows can fail attempting to rename edit log 
> segment files to a destination that already exists.
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-6197
>                 URL: https://issues.apache.org/jira/browse/HDFS-6197
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 3.0.0, 2.4.0
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>            Priority: Minor
>             Fix For: 3.0.0, 2.4.1
>
>         Attachments: HDFS-6197.1.patch
>
>
> As part of a rollback from a rolling upgrade in progress, we discard edit log 
> segments by renaming the file with suffix ".trash".  If no new edits arrive 
> in between multiple attempts, then the ".trash" file may still exist.  On 
> Windows, {{java.io.File#renameTo}} fails if the destination already exists 
> though.  This is visible right now as a failure in 
> {{TestRollingUpgrade#testRollback}} when running on Windows.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to