[ https://issues.apache.org/jira/browse/HDFS-5669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vinayakumar B updated HDFS-5669: -------------------------------- Attachment: HDFS-5669.patch Rebased the patch. > Storage#tryLock() should check for null before logging successfull message > -------------------------------------------------------------------------- > > Key: HDFS-5669 > URL: https://issues.apache.org/jira/browse/HDFS-5669 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode > Affects Versions: 2.2.0 > Reporter: Vinayakumar B > Assignee: Vinayakumar B > Attachments: HDFS-5669.patch, HDFS-5669.patch > > > In the following code in Storage#tryLock(), there is a possibility that > {{file.getChannel().tryLock()}} returns null if the lock is acquired by some > other process. In that case even though return value is null, a successfull > message confuses. > {code}try { > res = file.getChannel().tryLock(); > file.write(jvmName.getBytes(Charsets.UTF_8)); > LOG.info("Lock on " + lockF + " acquired by nodename " + jvmName); > } catch(OverlappingFileLockException oe) {{code} -- This message was sent by Atlassian JIRA (v6.2#6252)