[ 
https://issues.apache.org/jira/browse/HDFS-3128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13966914#comment-13966914
 ] 

Tsz Wo Nicholas Sze commented on HDFS-3128:
-------------------------------------------

> However, other parts of this change altered where tests created files in HDFS 
> MiniDFSClusters. These parts were not needed,...

These changes actually are incorrect since test.build.data is a conf for the 
local file system.  It should not be used in HDFS MiniDFSClusters anyway.

> Overall, I think this problem is bound to keep occurring until we get Windows 
> build slaves. ...

Sure, if there were Windows Jenkins builds, the bug would be caught earlier.   
Or if the contributors/reviewers could spend more time to understand the code 
first, the bug would also be caught.  Simply searching and replacing the code 
without first understanding them is something that we should avoid.

> Unit tests should not use a test root in /tmp
> ---------------------------------------------
>
>                 Key: HDFS-3128
>                 URL: https://issues.apache.org/jira/browse/HDFS-3128
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.3.0
>            Reporter: Eli Collins
>            Assignee: Andrew Wang
>            Priority: Minor
>             Fix For: 2.4.0
>
>         Attachments: hdfs-3128-1.patch
>
>
> Saw this on jenkins, TestResolveHdfsSymlink#testFcResolveAfs creates 
> /tmp/alpha which interferes with other executors on the same machine.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to