[
https://issues.apache.org/jira/browse/HDFS-6305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13988180#comment-13988180
]
Chris Nauroth commented on HDFS-6305:
-------------------------------------
Nice work, Daryn. Thank you for adding the failure tests too. I have just one
question.
bq. The json decoding routines do not validate the expected fields are present
which may cause NPEs.
It wasn't clear to me if this patch is really doing anything to address this
part. I don't see addition of explicit validation checks, and it also doesn't
look like an NPE would be handled any differently. Can you please clarify?
Thanks!
> WebHdfs response decoding may throw RuntimeExceptions
> -----------------------------------------------------
>
> Key: HDFS-6305
> URL: https://issues.apache.org/jira/browse/HDFS-6305
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: webhdfs
> Affects Versions: 2.0.0-alpha, 3.0.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Priority: Critical
> Attachments: HDFS-6305.patch
>
>
> WebHdfs does not guard against exceptions while decoding the response
> payload. The json parser will throw RunTime exceptions on malformed
> responses. The json decoding routines do not validate the expected fields
> are present which may cause NPEs.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
