[
https://issues.apache.org/jira/browse/HDFS-6301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13988463#comment-13988463
]
Andrew Wang commented on HDFS-6301:
-----------------------------------
This patch needs a small rebase, but overall looks good. A few review comments:
* Why do we need to modify OP_ADD, and have xattrs be an argument to
unprotectedAddFile? AFAIK new files don't have any xattrs until they're set.
The other use of OP_ADD is for append, which also does not involve setting
xattrs. This looks like c+p from the ACL code, which needs it because of
default ACLs.
* buildXattrs, should we mask the getNameSpace() for paranoia?
* Have you done a full test run? I know for one that DFSTestUtil#runOperations
needs to be updated with the new op, and the test resources related to
TestOfflineEditsViewer will need to be updated. These are fairly mechanical and
we can do it in a follow-on if you like.
Thanks Yi.
> NameNode: persist XAttrs in fsimage and record XAttrs modifications to edit
> log.
> --------------------------------------------------------------------------------
>
> Key: HDFS-6301
> URL: https://issues.apache.org/jira/browse/HDFS-6301
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: HDFS XAttrs (HDFS-2006)
> Reporter: Yi Liu
> Assignee: Yi Liu
> Fix For: HDFS XAttrs (HDFS-2006)
>
> Attachments: HDFS-6301.patch
>
>
> Store XAttrs in fsimage so that XAttrs are retained across NameNode restarts.
> Implement a new edit log opcode, {{OP_SET_XATTRS}}.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
