[ 
https://issues.apache.org/jira/browse/HDFS-6334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13995957#comment-13995957
 ] 

Aaron T. Myers commented on HDFS-6334:
--------------------------------------

Patch looks great to me, Kihwal. Thanks for doing it. Two little nits:

# bq. +   * used, a special token handling mat be needed to make sure a token 
acquired 
s/mat/may/g
# The method comment for {{ConfiguredFailoverProxyProvider#useLogicalURI}} says 
"Logical URI is not used for IP failover." While strictly true, I'm guessing 
you meant to put a different comment here.

+1 once these are addressed.

> Client failover proxy provider for IP failover based NN HA
> ----------------------------------------------------------
>
>                 Key: HDFS-6334
>                 URL: https://issues.apache.org/jira/browse/HDFS-6334
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Kihwal Lee
>            Assignee: Kihwal Lee
>         Attachments: HDFS-6334.patch, HDFS-6334.v2.patch
>
>
> With RPCv9 and improvements in the SPNEGO auth handling, it is possible to 
> set up a pair of HA namenodes utilizing IP failover as client-request fencing 
> mechanism.
> This jira will make it possible for HA to be configured without requiring use 
> of logical URI and provide a simple IP failover proxy provider.  The change 
> will allow any old implementation of {{FailoverProxyProvider}} to continue to 
> work.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to