[ https://issues.apache.org/jira/browse/HDFS-6328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13993786#comment-13993786 ]
Jing Zhao commented on HDFS-6328: --------------------------------- The latest patch looks good to me. Only one nit: the comment "// src[i - 1] is the last common ancestor." should be moved after the while loop. Other than this +1 (Maybe you do not need to run Jenkins again after moving the comment). > Simplify code in FSDirectory > ---------------------------- > > Key: HDFS-6328 > URL: https://issues.apache.org/jira/browse/HDFS-6328 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: namenode > Reporter: Haohui Mai > Assignee: Haohui Mai > Attachments: HDFS-6328.000.patch, HDFS-6328.001.patch, > HDFS-6328.002.patch, HDFS-6328.003.patch, HDFS-6328.004.patch > > > This jira proposes: > # Cleaning up dead code in FSDirectory. > # Simplify the control flows that IntelliJ flags as warnings. > # Move functions related to resolving paths into one place. -- This message was sent by Atlassian JIRA (v6.2#6252)