[ 
https://issues.apache.org/jira/browse/HDFS-6377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13995977#comment-13995977
 ] 

Uma Maheswara Rao G edited comment on HDFS-6377 at 5/13/14 2:50 AM:
--------------------------------------------------------------------

Thanks Andrew. 
Unifying xattr name and value limits into a single limit is OK for me.  
I think in existing filesystems it should depend on the implementation, for 
example in XFS they are separate limits: 
http://en.wikipedia.org/wiki/Extended_file_attributes. 

Furthermore, can we modify the configuration name according to [~cnauroth]'s 
comments:
{quote}The defaults chosen in this patch look reasonable to me with 
consideration of the use case driving xattrs. However, I wonder if the property 
name should include "fs-limits" for consistency with the other metadata 
limitation properties: dfs.namenode.fs-limits.max-component-length and 
dfs.namenode.fs-limits.max-directory-items. What do you think?{quote}

+1 for me, and I'd like we modify the configuration name.


was (Author: hitliuyi):
Thanks Andrew. 
I think unifing xattr name and value limits into a single limit is OK for me.  
I think in existing filesystems it should depend on the implementation, for 
example in XFS they are separate limits: 
http://en.wikipedia.org/wiki/Extended_file_attributes. 

Furthermore, can we modify the configuration name according to [~cnauroth]'s 
comments:
{quote}The defaults chosen in this patch look reasonable to me with 
consideration of the use case driving xattrs. However, I wonder if the property 
name should include "fs-limits" for consistency with the other metadata 
limitation properties: dfs.namenode.fs-limits.max-component-length and 
dfs.namenode.fs-limits.max-directory-items. What do you think?{quote}

+1 for me, and I'd like we modify the configuration name.

> Unify xattr name and value limits into a single limit
> -----------------------------------------------------
>
>                 Key: HDFS-6377
>                 URL: https://issues.apache.org/jira/browse/HDFS-6377
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: HDFS XAttrs (HDFS-2006)
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: hdfs-6377-1.patch
>
>
> Instead of having separate limits and config options for the size of an 
> xattr's name and value, let's use a single limit.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to