[ 
https://issues.apache.org/jira/browse/HDFS-6377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13996396#comment-13996396
 ] 

Charles Lamb commented on HDFS-6377:
------------------------------------

In general, LGTM. One nit (piling on Uma's comment):

+          "XAttr is too big, maximum size = " + nnConf.xattrMaxSize
+              + ", but the size is = " + xAttr.getName().length());

Could we change the wording to

"The XAttr is too big. The maximum size of the name + value is 
<nnConf.xattrMaxSize>, but the total size is <xAttr.getName().length().

+1 from me modulo that.


> Unify xattr name and value limits into a single limit
> -----------------------------------------------------
>
>                 Key: HDFS-6377
>                 URL: https://issues.apache.org/jira/browse/HDFS-6377
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: HDFS XAttrs (HDFS-2006)
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: hdfs-6377-1.patch
>
>
> Instead of having separate limits and config options for the size of an 
> xattr's name and value, let's use a single limit.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to