[
https://issues.apache.org/jira/browse/HDFS-6362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13993685#comment-13993685
]
Arpit Agarwal commented on HDFS-6362:
-------------------------------------
bq. Please justify why no new tests are needed for this patch.
There is an existing {{TestComputeInvalidateWork}} that failed to catch this
failure mode. Since we are replacing the String key with the {{DatanodeInfo}}
type safety checks will guard against this kind of bug.
> InvalidateBlocks is inconsistent in usage of DatanodeUuid and StorageID
> -----------------------------------------------------------------------
>
> Key: HDFS-6362
> URL: https://issues.apache.org/jira/browse/HDFS-6362
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Affects Versions: 2.4.0
> Reporter: Arpit Agarwal
> Assignee: Arpit Agarwal
> Priority: Blocker
> Attachments: HDFS-6362.01.patch, HDFS-6362.02.patch,
> HDFS-6362.03.patch
>
>
> {{InvalidateBlocks}} must consistently use datanodeUuid as the key. e.g. add
> and remove functions use datanode UUID and storage ID.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
