[
https://issues.apache.org/jira/browse/HDFS-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14005226#comment-14005226
]
Andrew Wang commented on HDFS-6435:
-----------------------------------
Hi ATM, thanks for working on this. I only have some nitty review comments:
IdUserGroup:
* Extra newline by the new config key
* Minor, but do you want to define the Patterns for the regexs in
{{parseStaticMap}} once rather than compiling them each time?
* On comment parsing, the {{startsWith}} and {{matches}} at the top look like
the do the same thing, did you mean for the {{matches}} to check for zero or
more spaces followed by a {{#}}? Could maybe get rid of the {{startsWith}}
entirely then. There's also another comment check in {{lineComponents[0]}} that
might be unnecessary since the entire line is already verified with the big
regex.
+1 once addressed, mostly optional.
> Add support for specifying a static uid/gid mapping for the NFS gateway
> -----------------------------------------------------------------------
>
> Key: HDFS-6435
> URL: https://issues.apache.org/jira/browse/HDFS-6435
> Project: Hadoop HDFS
> Issue Type: New Feature
> Components: nfs
> Affects Versions: 2.4.0
> Reporter: Aaron T. Myers
> Assignee: Aaron T. Myers
> Attachments: HDFS-6435.patch
>
>
> It's quite reasonable that folks will want to access the HDFS NFS Gateway
> from client machines where the UIDs/GIDs do not line up with those on the NFS
> Gateway itself. We should provide a way to map these UIDs/GIDs between the
> systems.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
