[ 
https://issues.apache.org/jira/browse/HDFS-6464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014816#comment-14014816
 ] 

Charles Lamb commented on HDFS-6464:
------------------------------------

Hi [~yi.a.liu]

Thanks for handling this. A few comments:

The change to XAttrHelper.java is just white space so you can leave it out.

In NameNodeWebHdfsMethods, when would xattrName.getXAttrName be null in:

          if (xattrName.getXAttrName() != null) {
            names.add(xattrName.getXAttrName());



> Support multiple xattr.name parameters for WebHDFS getXAttrs.
> -------------------------------------------------------------
>
>                 Key: HDFS-6464
>                 URL: https://issues.apache.org/jira/browse/HDFS-6464
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: webhdfs
>    Affects Versions: 3.0.0
>            Reporter: Yi Liu
>            Assignee: Yi Liu
>             Fix For: 3.0.0
>
>         Attachments: HDFS-6464.patch
>
>
> For WebHDFS getXAttrs through names, right now the entire list is passed to 
> the client side and then filtered, which is not the best choice since it's 
> inefficient and precludes us from doing server-side smarts on par with the 
> Java APIs. 
> Furthermore, if some xattrs doesn't exist, server side should return error.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to