[
https://issues.apache.org/jira/browse/HDFS-6473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14019193#comment-14019193
]
Andrew Wang commented on HDFS-6473:
-----------------------------------
Hey Charles, took a look. Looks basically right, had a few comments though:
- Why listEZ and showEZ? Seems redundant, and are named very similarly.
- Maybe call it "encryption.proto" rather than "EncryptionZone.proto", since we
might be adding ops not directly related to a Zone at some point.
- CreateEZRequestProto field numbers go 1 then 3, rather than 1 2.
- Seems like we should have a protobuf for key and IV, since it's also in the
LocatedBlocksProto.
- DFSClient, some of the unwrapped exceptions aren't actually thrown
- HdfsAdmin, let's work on specifying less generic exception types.
AccessControlException and FileNotFoundException should probably be mentioned.
Do we want a new {{UnknownKeyException}} or similar if it's not present in the
KeyProvider?
- I don't consider "encryption zone" a proper noun, let's lower case it. Same
for "extended attribute".
- s/Key Management System/KeyProvider/, same for KMS. Side note, it's also
Server not System.
- Should use self-closing {{<p/>}} tags.
- EncryptionZone, needs class javadoc, let's also use HashCodeBuilder and
EqualsBuilder from Apache Commons or Guava. This is stylistic, but a factory
method might be better than a builder, since this is a really simple class.
- I'd prefer just to leave out the FSNamesystem and new test, not much value in
the current state. Can save em for later.
> Protocol and API for Encryption Zones
> -------------------------------------
>
> Key: HDFS-6473
> URL: https://issues.apache.org/jira/browse/HDFS-6473
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: security
> Reporter: Charles Lamb
> Assignee: Charles Lamb
> Attachments: HDFS-6473.1.patch, HDFS-6473.2.patch
>
>
> Create the client/NN protocol for encryption zones.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
