[ 
https://issues.apache.org/jira/browse/HDFS-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jing Zhao updated HDFS-4667:
----------------------------

    Attachment: HDFS-4667.002.patch

Sorry for the long time delay, Binglin. Upload a patch that extends your v1 
patch and tries to cover multiple corner cases. In general the patch does the 
following:
1. Similar with your v1 patch, I use a map to capture the source and target of 
rename operations. But the new patch only handles reference nodes in this 
scenario to keep the change smaller.
2. When computing diff recursively, only handles files/dirs that still exist in 
the time frame of the later snapshot, as well as the files/dirs that were 
renamed and the rename targets are under the same snapshottable directory.
3. Mark a file as modified only if its file length or metadata has changed.
4. Delete the unused getPathComponentsWithSnapshot method and its unit tests.

The patch still needs more javadoc and some cleanup. Also I will add more unit 
tests.

> Capture renamed files/directories in snapshot diff report
> ---------------------------------------------------------
>
>                 Key: HDFS-4667
>                 URL: https://issues.apache.org/jira/browse/HDFS-4667
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>            Reporter: Jing Zhao
>            Assignee: Binglin Chang
>         Attachments: HDFS-4667.002.patch, HDFS-4667.demo.patch, 
> HDFS-4667.v1.patch, getfullname-snapshot-support.patch
>
>
> Currently in the diff report we only show file/dir creation, deletion and 
> modification. After rename with snapshots is supported, renamed file/dir 
> should also be captured in the diff report.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to