[
https://issues.apache.org/jira/browse/HDFS-6430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yi Liu updated HDFS-6430:
-------------------------
Attachment: HDFS-6430.3.patch
Update the patch for the comments.
{quote}
Looks like there are some whitespace issues going on
{quote}
OK, remove some whitespace
{quote}
HttpFSFileSystem.java
lines 1129 and 1146 - a foreach() style loop might be marginally more clear
Please add javadoc for new functions
{quote}
OK, use foreach() and add javadoc for the two internal methods.
{quote}
FSOperations.java
line 259 - could probably also be replaced by foreach()
{quote}
OK, use foreach()
{quote}
HttpFSParametersProvider.java
line 487 - should this be a constant somewhere?
{quote}
Now, it’s constant.
{quote}
HttpFSServer.java
lines 341, 349, 568, 577 - don't you need some note about the operation that's
being performed in the audit message?
{quote}
Add simple notes.
{quote}
BaseTestHttpFSWith.java
I like the tests.
Would be nice if you could also test different formats for values other than hex
Some negative tests - like invalid param/value would be nice (I guess I should
have done this for the acl tests...)
{quote}
add some negative tests using invalid name.
The value is byte[], so there is no different formats.
{quote}
EnumSetParam.java
parse() - isn't the code in the for loop just a split(",")? If not, how not?
toString() - wouldn't a foreach() be easier here, too?
{quote}
OK, Use split(“,”).
Iterator is simple too.
> HTTPFS - Implement XAttr support
> --------------------------------
>
> Key: HDFS-6430
> URL: https://issues.apache.org/jira/browse/HDFS-6430
> Project: Hadoop HDFS
> Issue Type: Task
> Affects Versions: 3.0.0
> Reporter: Yi Liu
> Assignee: Yi Liu
> Fix For: 3.0.0
>
> Attachments: HDFS-6430.1.patch, HDFS-6430.2.patch, HDFS-6430.3.patch,
> HDFS-6430.patch
>
>
> Add xattr support to HttpFS.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
