[ https://issues.apache.org/jira/browse/HDFS-5574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14032230#comment-14032230 ]
Hadoop QA commented on HDFS-5574: --------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12619705/HDFS-5574.v5.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 4 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.metrics2.impl.TestMetricsSystemImpl org.apache.hadoop.ha.TestZKFailoverControllerStress {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7127//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7127//console This message is automatically generated. > Remove buffer copy in BlockReader.skip > -------------------------------------- > > Key: HDFS-5574 > URL: https://issues.apache.org/jira/browse/HDFS-5574 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: Binglin Chang > Assignee: Binglin Chang > Priority: Trivial > Attachments: HDFS-5574.v1.patch, HDFS-5574.v2.patch, > HDFS-5574.v3.patch, HDFS-5574.v4.patch, HDFS-5574.v5.patch > > > BlockReaderLocal.skip and RemoteBlockReader.skip uses a temp buffer to read > data to this buffer, it is not necessary. -- This message was sent by Atlassian JIRA (v6.2#6252)