[
https://issues.apache.org/jira/browse/HDFS-6492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14034229#comment-14034229
]
Charles Lamb commented on HDFS-6492:
------------------------------------
LGTM. I only have a few picky little nits.
The javadoc you added needs an @returns.
final decls. I see a few in args, but generally none in method bodies. I'm
whiny about this as you know. I'd be happy if you did a query-replace
s/List<XAttr>/final List<XAttr>.
s/verifing/verifying/
I prefer 'for (int i = 0; i < numToAdd; i++)' to 'for (int i=0; i<numToAdd;
i++)'. I think the Java coding standards support that.
We discussed (offline) the lack of mkdir support in fseditlog. I just wanted to
add it to the Jira for the record.
I thought import foo.* was not in the Java coding standard.
> Support create-time xattrs and atomically setting multiple xattrs
> -----------------------------------------------------------------
>
> Key: HDFS-6492
> URL: https://issues.apache.org/jira/browse/HDFS-6492
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Affects Versions: 2.4.0
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Attachments: HDFS-6492.001.patch, HDFS-6492.002.patch
>
>
> Ongoing work in HDFS-6134 requires being able to set system namespace
> extended attributes at create and mkdir time, as well as being able to
> atomically set multiple xattrs at once. There's currently no need to expose
> this functionality in the client API, so let's not unless we have to.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
